This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
fix: Events related to different process instances may be collected in one bunch #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igdianov
changed the title
igdianov
changed the title
igdianov
force-pushed
the
igdianov-2558-audit-events-clash
branch
from
1bb6a19
to
6581f10
Compare
igdianov
changed the title
igdianov
force-pushed
the
igdianov-2558-audit-events-clash
branch
2 times, most recently
from
0e91bbd
to
813f7dd
Compare
erdemedeiros
reviewed
Mar 6, 2019
...org/activiti/cloud/services/events/listeners/MessageProducerCommandContextCloseListener.java
Show resolved
Hide resolved
...me-bundle/src/test/java/org/activiti/cloud/starter/tests/services/audit/AuditProducerIT.java
Outdated
Show resolved
Hide resolved
igdianov
force-pushed
the
igdianov-2558-audit-events-clash
branch
from
813f7dd
to
90bea3a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #257 +/- ##
=============================================
- Coverage 73.41% 73.18% -0.24%
Complexity 5 5
=============================================
Files 114 114
Lines 1471 1484 +13
Branches 42 47 +5
=============================================
+ Hits 1080 1086 +6
- Misses 355 359 +4
- Partials 36 39 +3
Continue to review full report at Codecov.
|
salaboy
approved these changes
Mar 15, 2019
erdemedeiros
approved these changes
Mar 15, 2019
igdianov
force-pushed
the
igdianov-2558-audit-events-clash
branch
from
90bea3a
to
a9d96ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes common problem that maps execution attributes for all events types as well as fixes the issue that mixes execution context attributes for multiple executions in the same transaction.
This test ensures the execution attributes are mapped correctly for subprocesses as well as other events
Unfortunately, I had to remove execution attribute headers from message itself as there is no way to use same headers for different executions for events generated in a single transactions, so message headers will have only common runtime bundle properties...
Fixes Activiti/Activiti#2558